Threaded Mode | Linear Mode

Valery · 08.01.2018 04:18

Yeah, thats why the TL. UN:R does simply not work if changes are done within dialog, tried everything. Is like updating battlefield from dialog, needs a special SN or UN:C

Berserker · 08.01.2018 06:37

Val, where is your DL:S command? Update must be right after it.

Valery · 08.01.2018 07:02

DL:S opens dialog, DL:C closes it. So it is after closing, I have no idea how to use this other way.

RoseKavalier · 08.01.2018 08:35

In plugin I simply call 0x417380 (redraws everything on adventure map) after dialog is closed, it updates with no issues.
I don't know if you can call a function from ERM with arguments but it's basically:

Code:

__thiscall([0x6992B8], 1, 0) ~~~

__asm{

    MOV ECX, DWORD PTR DS : [0x6992B8]

    PUSH 0

    PUSH 1

    MOV EAX, 0x417380

    CALL EAX

}

I guess it may be the same function... ERM noobie 118

EDIT: according to WoG source, it's partial use of 0x417380 function so it may be missing something.

Code:

void RedrawMap(void)

{

  #include "templ.h"

  __asm{

    mov    ecx,0x6992B8

    mov    ecx,[ecx]

// ïåðåðèñîâûâàåò ýêðàí advanture

// ecx -> advManager

    mov    ecx,[ecx+0x44]

// âûëåòàåò, åñëè íóëü

    or     ecx,ecx

    je     l_not

   push   ecx

    push   1

    push   1

    push   0xFFFFFFFF

    mov    eax,0x4032E0

    call   eax

   pop    ecx

    push   1

    push   1

    push   0xFFFFFFFF

    mov    eax,0x403420

    call   eax

// ïåðåðèñîâûâàåò ïðàâîå íèæíåå îêíî êàðòû

    mov    ecx,0x6992B8

    mov    ecx,[ecx]

//    mov    ecx, -> advManager

    push   1

    push   1

    push   1

    mov    eax,0x415D40

    call   eax

  }

l_not:;  

  RETURNV

}

Berserker · 08.01.2018 16:32

Valery, DL:C simply sets variable to close dialog, but does not close immediately. I do not see any DL:S in your code (((

RoseKavalier, yep, thanks. In ERM it's !!UN:R1, but "right after close" is right after calling Dialog Show (!!DL:S) in ERM. Val is trying to call redraw IN EVENT HANDLER, not after dialog is closed.

Valery · 08.01.2018 16:43

Well of course there is a DL:S because I need to open the dialog))

Here is short version of what is done when level is modified:

!?FU77003;
!!SN:X?y1; get key code to y1
!!SN:W^Ykey^/?y2;
!!VRy2&y2<113:S113; set to F2 by default if mod is loaded during game
!!FU&y1<>y2:E;
!!SN:L^Era.dll^/?y2; received description of Era library in y2
!!SN:Ay2/^GetGameState^/?y3; y3 — address of function GetGameState
!!SN:Ey3/1/?y4; y4 — ID of parent dialog, y5 — ID of current dialog
!!FU&y5<>4205280:E; exit, if this is not battle
!!SN:X?y1/1;
[set variables etc etc...]
!!DL550:S1;
!!CM:R0;

Then modify stats

*********************Primary Skills***************************
!?FU7780017;
!!HEx1:F?y1/?y2/?y3/?y4;
!!VRz16:M3/y1; !!VRz16&y1=125:S^{~Red}125{~}^; set 125 cap
!!VRz17:M3/y2; !!VRz17&y2=125:S^{~Red}125{~}^;
!!VRz18:M3/y3; !!VRz18&y3=125:S^{~Red}125{~}^;
!!VRz19:M3/y4; !!VRz19&y4=125:S^{~Red}125{~}^;
!!DL550:A141/3/z16/1 A142/3/z17/1 A143/3/z19/1 A144/3/z18/1;
!?DL&v998=550/v999>219/v999<228/v1000=13; buttons adding priùary skills
!!SN:W^Val_Hero^/?y1;
!!HEy1:F?y2/?y3/?y4/?y5;
!!HEy1&v999=220/y2<125:Fd1/d/d/d;
!!HEy1&v999=221/y3<125:Fd/d1/d/d;
!!HEy1&v999=222/y4<125:Fd/d/d/d1;
!!HEy1&v999=223/y5<125:Fd/d/d1/d;
!!HEy1&v999=224/y2>0:Fd-1/d/d/d;
!!HEy1&v999=225/y3>0:Fd/d-1/d/d;
!!HEy1&v999=226/y4>0:Fd/d/d/d-1;
!!HEy1&v999=227/y5>0:Fd/d/d-1/d;
!!FU7780017:Py1;
;How to redraw?
********************End primary skills*************************

And finally close:

!?DL&v998=550/v999=30722/v1000=13; close
!!DL550:C1;
[...reset all SN:W values...]
;place in last position the following
!!SN:W^Val_Levelcounter^/?y5;
!!if&y5>0:;
!!SN:W^Val_Hero^/?y3;
!!HEy3:E?y1/?y2;
!!VRy2:+y5; increase hero level by 1
!!FU7780016:Py2/?v2;
!!VRv2:-y1;
!!HEy3:Edv2;
!!HEy3:E?y1/?y2;
!!en:;
!!UN:R1; [original code]

So I modify stats, close dialog, but now in map to see any change I have to click somewhere, otherwise it shows same values as before. An update problem./

Berserker · 08.01.2018 16:48

!!DL550:S1;
Insert update command right after it. It may be enclosed in condition. If SHOULD_UPDATE then update. Any global variable with suit.

!!DL:S
!!if (some update w-var is set)
; update!
!!en:;

Valery · 08.01.2018 17:05

Now thats silly, it works. I can't still get the mechanics of why it works, but it works, all updated. Thanks a lot.

Final version of trainer uploaded.

Berserker · 08.01.2018 17:18

It's not silly, because !!DL:C does not close dialog, but only marks it for closing. Dialog is still on the screen. After all !?DL triggers execution WoG will close dialog. So you call update while dialog is still on the screen. Real updates can be performed after DL:S command. Here all !?DL triggers already executed, dialog is closed and you are free.

Valery · 08.01.2018 17:21

I see (for me still doesn't make sense as the command to update is done before any action took place, but I don't know the internals). Is interesting that Jim didn't see this, then went into TL triggers which made the mod very unstable.

Berserker · 08.01.2018 18:29

Jim likes to experiment )

gamecreator · 08.01.2018 19:50

(08.01.2018 17:05)Valery Wrote: Now thats silly, it works. I can't still get the mechanics of why it works, but it works, all updated.

Because your script is paused when you display the dialog. It resumes after the dialog is closed.

feanor · 08.01.2018 21:04

(07.01.2018 02:31)Berserker Wrote: При отвязке от карты появляются возможности для единообразного добавления скриптов на Lua, можно распространять ресурсы отдельно (не только скрипты), можно применять оптимизации (в 2.55 загрузка гораздо быстрее, так как ЕРМ остаётся тем же в большинстве случаев загрузки). +Часть багов связана именно с поддержкой событий карт.
Современные карты-моды распространяются в виде модов, поскольку и писать ЕРМ в событиях, мягко скажем, неудобно, и отлаживать в карте невозможно без рестарта.

а) легаси. Много мелкого легаси.
б) распространение ресурсов отдельно - минус, а не плюс.
в) ориентация на картомоды, которых считанные единицы, вместо карт с полутора снипплетами (отключение командиров etc), я полагаю, неверна.

Ну и принуждение к удобству..ну такое.

Компромиссным вариантом была бы выгрузка скриптов (при их наличии) из файла карты с папку перед загрузкой

Berserker · 08.01.2018 23:55

feanor, а утилита, которая извлекает из карты скрипты в папку будет компромиссом? Уже писал такой скрипт.

Valery · 09.01.2018 04:02

(08.01.2018 19:50)gamecreator Wrote: Because your script is paused when you display the dialog. It resumes after the dialog is closed.

yes I did a test and now I see what you mean. Before I thought that this won't work:

!?CM0;
!!UN:R2; update resources bar
!!OW:R0/6/d5000; add resources

and needs to be

!?CM0;
!!OW:R0/6/d5000; add resources
!!UN:R2; update resources bar

But in fact it works. Somehow it looks weird to me that it is being updated before script is activated but there is the evidence.

Threaded Mode \| Linear Mode ERA II » WoG Era 2: Русская и Английская версии
Author	Message