Archer30
Posts: 1175
|
|
01.05.2022 01:16 |
|
Berserker
Posts: 16657
|
|
01.05.2022 02:51 |
|
myoffice91
Posts: 88
|
Berserker,
Quote:Вчера, обнаружил в окне "ВЫБЕРИТЕ КАМПАНИЮ" из "Клинок армагеддона", что создает поток 5, а если нажать "Назад", то поток не уничтожается. То есть, это оригинальный баг, похоже утечка памяти.
Есть решение:
изменить:
0045EE4F | 81FB 98C66600 | cmp ebx,66C698 | ebx:&"AB.h3c"
на
0045EE4F | 81FB F8CA6600 | cmp ebx,66CAF8 | ebx:&"AB.h3c"
Где при нажатии кнопки кампании, например "Возрождение эрафии"
0045EA2A | 8A4437 60 | mov al,byte ptr [edi+esi+60] | - это активная кнопка с изображением. Всего 3 кнопки с видео.
0045EA3B | 83FE 14 | cmp esi,14h (20) цикл
- Heroes 3 MoP Fan-Patch 3.14
- MoP Key Delete RandomMap
- TavernVideos BIK ASM
|
|
03.05.2022 23:08 |
|
Berserker
Posts: 16657
|
|
04.05.2022 03:54 |
|
Archer30
Posts: 1175
|
Reporting a problem only with the latest ERA testing version:
There is a chance my DW receiver could be broken (incorrect internal number) with correct dwelling coordinates. The coordinates were found by UN:U. By checking the found coordinates with OB:T, the result showed it was a legal dwelling.
Here are screenshots after I renewed my testing map several times. Erm error happens on several erms at the same time.
Screenshots - Imgur
Here is a testing mod for reproducing the issue, as well as my debug folders generated by pressing Yes on these three screenshots. Note that the problem happens by chance with unknown condition, cant promise the mod is eligible to reproduce.
Downlod the testing mod
Hawaiing also reported a similar problem with CB, although unfotunately I could not retrieve the debug folder from him. At the moment we have play with UN:P904/905 to bypass the problem.
____
Edit: Proposing these to be added to EEF. it's very important as in Battlereplay the two vars could be changed.
Latest ERA mods and scripts in development - My GitHub
(This post was last modified: 06.05.2022 20:55 by Archer30.)
|
|
06.05.2022 11:11 |
|
Archer30
Posts: 1175
|
There is another issue I believe is with the engine. For some reason, CA:O returns invalid values or possibly OW is broken at processing a correct value, I can't check for details as I didn't have more info from players.
Screenshot:
My erm:
As you see, the value passing to OW:I is fetched by CA:O. I can't think of a reason CA:O could return a value out of the range -1 ~ 7.
Latest ERA mods and scripts in development - My GitHub
(This post was last modified: 07.05.2022 08:32 by Archer30.)
|
|
07.05.2022 08:31 |
|
Berserker
Posts: 16657
|
I think OW:I will not work with negative values. Add a check for valid owner.
Quote:Edit: Proposing these to be added to EEF.
Agree. Could you add those lines and send updated code to daemon_n?
Quote:There is a chance my DW receiver could be broken (incorrect internal number) with correct dwelling coordinates
Maybe wrong object replacement with invalid OB:C value?
Скачать Герои 3 Эра и всё, что с ней связано / ERA 2.46f для старых модов
Поддержать проект
|
|
07.05.2022 14:59 |
|
daemon_n
Posts: 4343
|
|
07.05.2022 18:36 |
|
Archer30
Posts: 1175
|
Berserker,
Quote:I think OW:I will not work with negative values. Add a check for a valid owner.
Then "!!OW - owner out of range ( -1..7)" is a lie. If -1 is not acceptable, many scripts have to be corrected. But I don't believe so, we used to use OW with -1 for years.
Quote:Could you add those lines and send the updated code to daemon_n?
Sure, the latest EEF, maintained by the Launcher Team can always be found here
Quote:Maybe wrong object replacement with invalid OB:C value?
Can't be sure. The error happens by chance. Nothing was changed, I just keep recreating a game with the same map, and then the error appeared. If your assumption is true, this script for adding extra creatures to type 17 dwellings would be the most suspicious. What do you think about it?
Neutral Neighborhood
Latest ERA mods and scripts in development - My GitHub
|
|
07.05.2022 22:55 |
|
Berserker
Posts: 16657
|
Quote:Then "!!OW - owner out of range (-1..7)" is a lie.
Just add a check if value is not in range then IF:M^value^.
Quote:What do you think about it?
Just comment all creature changing lines except the one tested and safe and try again to find out. Some filed overwrite or hidden bug/limitation may exist, but hardly it's something with Era engine.
Скачать Герои 3 Эра и всё, что с ней связано / ERA 2.46f для старых модов
Поддержать проект
|
|
08.05.2022 00:28 |
|
Archer30
Posts: 1175
|
|
09.05.2022 20:55 |
|
Archer30
Posts: 1175
|
|
13.05.2022 12:14 |
|
Berserker
Posts: 16657
|
|
13.05.2022 20:32 |
|
wessonsm
Posts: 792
|
По поводу этого бага.
Кажется виноват хук Эры по адресу 0x005BA547.
Если отменить хук, баг уходит (я использовал инструмент для удаления патчей Raistlin'а).
Вопрос: как это скажется на функциональности Эры в целом?
Этот хук появился где-то между 3.3 и 3.4, в 3.3.0 его еще нет.
|
|
15.05.2022 14:41 |
|